Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable content collection cache #8409

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Enable content collection cache #8409

merged 6 commits into from
Jun 5, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented May 30, 2024

Description (required)

  • Re-enables the experimental content collection caching feature

@vercel Vercel
Copy link

vercel bot commented May 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2024 8:29am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jun 5, 2024 8:29am

@delucis
Copy link
Member Author

delucis commented May 31, 2024

Looks like there's still a bug. Initial build for this branch succeeded, then when I re-ran the deployment with the same build cache, it failed.

@matthewp
Copy link
Contributor

@delucis how are you rerunning the deployment? I don't see it on the page. In any event, mind rerunning it again? I upgrade to the latest Astro, not sure if that's the reason yet, though.

@delucis
Copy link
Member Author

delucis commented May 31, 2024

Redeployed manually from the Vercel dashboard. Just triggered one again.

@delucis
Copy link
Member Author

delucis commented May 31, 2024

Seems to have failed again: https://vercel.com/astrodotbuild/docs/DVUyCuznbY7jLsaXChRui5LSxpwE

@matthewp
Copy link
Contributor

Ok thanks, think this is some extra information we need to retain in our cache manifest, will work on it.

@matthewp
Copy link
Contributor

@delucis I did a preview release with what I think is the fix. Can you try rerunning? Thanks.

@delucis
Copy link
Member Author

delucis commented May 31, 2024

Looking good! https://vercel.com/astrodotbuild/docs/CPitQx2B7xJkUTiUKZvbvFUCypvA

@delucis
Copy link
Member Author

delucis commented May 31, 2024

Marking this as a draft until withastro/astro#11170 is released.

@delucis delucis marked this pull request as draft May 31, 2024 23:47
@delucis delucis mentioned this pull request Jun 3, 2024
Merged
@delucis delucis marked this pull request as ready for review June 5, 2024 08:26
TheOtterlord
TheOtterlord approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🥳

@delucis delucis merged commit f20b129 into main Jun 5, 2024
8 checks passed
@delucis delucis deleted the chris/ccc branch June 5, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOtterlord TheOtterlord TheOtterlord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@delucis @matthewp @TheOtterlord