Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new getViteConfig() option for Vitest #8192

Merged
merged 4 commits into from
May 8, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented May 6, 2024

Description (required)

Updates the Vitest testing docs to mention a new config option.

For Astro version: 4.8. See astro PR withastro/astro#10963.

I did not use <Since /> in this case because it doesn’t really work well inline in the way I integrated these new docs. Any thoughts on whether this should be added somehow? There could be a separate heading to fit it under, but that felt a little artificial.

@delucis delucis added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label May 6, 2024
Copy link

vercel bot commented May 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 8, 2024 4:57pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 8, 2024 4:57pm

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 6, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/testing.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added this to the 4.8 milestone May 7, 2024
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels May 7, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @delucis !

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 8, 2024
@sarah11918
Copy link
Member

updating branch and pointing to 4.8.0 branch!

@sarah11918 sarah11918 changed the base branch from main to 4.8.0 May 8, 2024 15:30
@sarah11918 sarah11918 merged commit 8bb3031 into 4.8.0 May 8, 2024
2 of 3 checks passed
@sarah11918 sarah11918 deleted the dx-1250/get-vite-config branch May 8, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants