-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(ko-KR): use <Steps>
components for many files.
#8171
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
thank you All updates have been added. |
Reference pages reviewed for Steps/visual check! LGTM |
Deploy folder pages reviewed for Steps/visual check! LGTM |
Migrate to Astro folder pages reviewed for Steps/visual check! LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All steps in CMS guides look correct 🎉
The testing page is missing a few steps added later in #8096 |
The docker.mdx page has updated since this PR! You can find more changes here: #8226 |
Thank you so much for all this work @jsparkdev ! On talking and doc'ing today, we all checked the deploy preview pages to make sure the Steps components looked right, but that's ALL we checked! We haven't checked these for being up to date with any new docs merges, but did point out if we noticed in particular. So, following @yanthomasdev 's advice is still important! Otherwise, we've left comments as we checked for the Steps component only! 🙌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/recipes
is all 👍 and accurate, highlighting Sarah's comment wrt Docker
All updates have been completed. Thank you to everyone who reviewed. In particular, #8226, which updates the What part is wrong..? |
Your right @jsparkdev, everything is aligned in both PRs 🥳 keeping it in tabs for further resolves. Safe to say - LGTM 👍 |
thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
Description (required)
<Steps>
components for many files (Eduardo<Steps>
up! #8167)cosmic.mdx
#8082--omit=dev
for npm over deprecated--production
#8226Related issues & labels (optional)