Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images.mdx #7856

Merged
merged 7 commits into from
Apr 17, 2024
Merged

Update images.mdx #7856

merged 7 commits into from
Apr 17, 2024

Conversation

rishi-raj-jain
Copy link
Contributor

@rishi-raj-jain rishi-raj-jain commented Apr 11, 2024

Description (required)

Showcases the use of the relative image path without leading ./ in MDX file(s).

I am proposing this change in Astro docs to show how Astro users can use the particular functionality.

Yup, I've made change in only the english docs.

Related issues & labels (optional)

The related PR is withastro/astro#10754

Copy link

vercel bot commented Apr 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 17, 2024 11:08pm

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 11, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Rishi Raj Jain added 2 commits April 16, 2024 11:27
@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Apr 16, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion below!

src/content/docs/en/guides/images.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Apr 16, 2024
Rishi Raj Jain and others added 2 commits April 16, 2024 20:08
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good and will be ready to merge when the next release goes out!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Apr 16, 2024
@sarah11918
Copy link
Member

Looks like this was released, so good to merge now! 🥳

@sarah11918 sarah11918 merged commit ba35f74 into withastro:main Apr 17, 2024
7 of 8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
Co-authored-by: Sarah Rainsberger <[email protected]>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants