Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple cdn #7183

Closed
wants to merge 3 commits into from
Closed

Add multiple cdn #7183

wants to merge 3 commits into from

Conversation

peng
Copy link
Contributor

@peng peng commented Mar 4, 2024

Description

Add build.assetsPrefix config docs if is object.

We have discussed in this PR: #6982

Only submitted en docs. If is OK, I can translate zh docs.

Related issues & labels (optional)

PR: withastro/astro#10189

Issues discussed: withastro/astro#9700 (comment)

Opened discussion: withastro/roadmap#818

Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 6, 2024 11:29am

peng added 2 commits March 6, 2024 19:06
* main: (55 commits)
  i18n(es): Update fonts.mdx (withastro#7199)
  i18n(es): Update images.mdx translation (withastro#7197)
  i18n(ru): Add `image-service-reference.mdx` translation (withastro#7202)
  i18n(it): Updated tutorials and small fix to install (withastro#7087)
  i18n(it): Updated basics (withastro#7088)
  i18n(it): Updated guides (withastro#7085)
  i18n(ja): Update `configuration-reference.mdx` (withastro#7158)
  i18n(ru): Update `islands.mdx` translation (withastro#7195)
  i18n(ru): Update `astro-syntax.mdx` translation (withastro#7187)
  i18n(ru): Update `tutorial/1-setup/2.mdx` translation (withastro#7186)
  i18n(pt-BR): Create `authentication.mdx` (withastro#6951)
  i18n(hi): add `astro-pages.mdx` (withastro#7003)
  i18n(ko-KR): add `ecommerce.mdx` (withastro#7149)
  i18n(ru): Update `fonts.mdx` translation (withastro#7166)
  i18n(ru): Update `recipes.mdx` translation (withastro#7165)
  i18n(ru): Update `migrate-to-astro.mdx` translation (withastro#7164)
  i18n(ja): Update routing.mdx in ja (withastro#7101)
  [i18nIgnore] Update 1.mdx
  i18n(fr): Update `guides/fonts.mdx` and `tutorial/1-setup/2.mdx` (withastro#7189)
  i18n(fr): Update `guides/images.mdx` and `guides/rss.mdx`  (withastro#7151)
  ...
@sarah11918
Copy link
Member

Hi @peng ! I am again closing this docs PR because the changes should not be made to this file. They are only made in the JSDoc in the main astro repo, then will be copied into here.

You are welcome to add the translation, but only after the English has been merged and is live. Then, it will follow our normal translation process. Translations are only done after the English is in docs, and shows up on our tracker as needing translation here: https://i18n.docs.astro.build -- whatever needs updating there is available for anyone to translate!

In that case, for the translation only, you will change the appropriate zh file here in docs. Translations are done locally, here in this repo!

@sarah11918 sarah11918 closed this Mar 6, 2024
@peng
Copy link
Contributor Author

peng commented Mar 7, 2024

OK,Thanks ! I misunderstood. I thought that the note documentation in the astro project was updated, and I ran docgen in the docs project to automatically generate the en document and submit the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants