Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix option to change output sitemap filenames #6879

Closed
wants to merge 2 commits into from
Closed

Add prefix option to change output sitemap filenames #6879

wants to merge 2 commits into from

Conversation

ktym4a
Copy link
Contributor

@ktym4a ktym4a commented Feb 13, 2024 •
edited by sarah11918
Loading

Description (required)

Add prefix to sitemap options so that the filename can be changed optionally.

For @astrojs/sitemap version: 3.1. See astro PR withastro/astro#9846

@vercel Vercel
Copy link

vercel bot commented Feb 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 13, 2024 9:01pm

at-the-vr
at-the-vr reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@at-the-vr at-the-vr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an upcoming feature? I tried to run this on a stackblitz instance and it didn't worked there 😕
edit: forgot to mention - I also updated using npx @astrojs/upgrade

@ktym4a
Copy link
Contributor Author

ktym4a commented Feb 13, 2024

Is this an upcoming feature? I tried to run this on a stackblitz instance and it didn't worked there 😕

Yes, it is.
It will be released in astro v4.4.

@at-the-vr
Copy link
Member

at-the-vr commented Feb 13, 2024 •
edited
Loading

I could not find it in their milestone 😕, can you pinpoint it ?

@ktym4a
Copy link
Contributor Author

ktym4a commented Feb 13, 2024

I have received this comment so I am assuming it will be released in v4.4.
withastro/astro#9846 (comment)

@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Feb 13, 2024
@sarah11918
Copy link
Member

Ah, I see everyone's confusion! Because this is an integration minor, it doesn't release necessarily with Astro 4.4, but rather with the next version of @astrojs/sitemap! Integration packages release separately from core, and could be together but might not be!

I'll update the PR description!

sarah11918
sarah11918 reviewed Feb 13, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @ktym4a ! Just left a suggestion for the intro text, but you did a great job copying the style and code format of the other config options. Thank you for making this so easy! 🙌

src/content/docs/en/guides/integrations-guide/sitemap.mdx Outdated Show resolved Hide resolved
sarah11918
sarah11918 approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! We have added the label so that this gets merged when the new integration version is released, and not before. So nothing left for you to do! Thank you again for your contribution!

@kevinzunigacuellar
Copy link
Member

!coauthor

@github-actions GitHub Actions
Copy link 

Co-authored-by: ktym4a <[email protected]>
Co-authored-by: Atharva <[email protected]>
Co-authored-by: Sarah Rainsberger <[email protected]>

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Feb 17, 2024
@ktym4a
Copy link
Contributor Author

ktym4a commented Feb 21, 2024 •
edited
Loading

I share here that revert withastro/astro#9846.
details: withastro/astro#10179, withastro/astro#10171

@sarah11918
Copy link
Member

Hi @ktym4a !

I've checked with our core platform team, and they think the best thing to do with the reverting of the other PR is to close this docs PR right now.

This PR can be reopened if we go with this solution in future! Or, if another solution is created, a new Docs PR can be created!

So, I will close this one right now, but I think we are in a good place to know how to document a similar solution if it's implemented! 🙌

@sarah11918 sarah11918 closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-the-vr at-the-vr at-the-vr left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ktym4a @at-the-vr @sarah11918 @kevinzunigacuellar