Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get remote dimensions #6797

Merged
merged 9 commits into from
Feb 15, 2024
Merged

Get remote dimensions #6797

merged 9 commits into from
Feb 15, 2024

Conversation

OliverSpeir
Copy link
Contributor

@OliverSpeir OliverSpeir commented Feb 6, 2024 •
edited
Loading

Description (required)

Add inferSize property and update the wording of widths and heights property to Images component (which is source of truth for getImage and Picture as well)

Related PR

withastro/astro#9976

For Astro version: 4.4

@vercel Vercel
Copy link

vercel bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 15, 2024 11:27am

@OliverSpeir OliverSpeir mentioned this pull request Feb 6, 2024
Merged
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Feb 6, 2024
@sarah11918 sarah11918 added this to the 4.4.0 milestone Feb 6, 2024
sarah11918
sarah11918 reviewed Feb 8, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this wonderfully helpful feature, and for helping me make this as helpful for the readers to truly get this amazing work! 💪

src/content/docs/en/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/images.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/images.mdx Outdated Show resolved Hide resolved
@OliverSpeir
Copy link
Contributor Author

I'm curious why this example shows BOTH the dimensions AND inferSize={true}

I think the idea was going to be we'd do ins and del with expressive code, but I don't think it actually looks as good as just marking the inferSize property

I added a note about unauthorized remote images, it made things feel a bit long but I'll see what y'all think

@sarah11918 sarah11918 mentioned this pull request Feb 14, 2024
Merged
@delucis delucis merged commit c2a8a9c into withastro:main Feb 15, 2024
7 checks passed
@huyikai huyikai mentioned this pull request Feb 16, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@OliverSpeir @sarah11918 @delucis