Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApostropheCMS integration 🙏 #5969

Merged
merged 5 commits into from
Jan 17, 2024
Merged

ApostropheCMS integration 🙏 #5969

merged 5 commits into from
Jan 17, 2024

Conversation

boutell
Copy link
Contributor

@boutell boutell commented Dec 27, 2023

Description (required)

Add ApostropheCMS to the CMS guide.

Compatibility

Tested compatible with both Astro 3.x and Astro 4.x, but of course our starter projects and documentation are using 4.x.

Thank you!

Copy link

vercel bot commented Dec 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 17, 2024 1:19pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 1:19pm

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Dec 27, 2023
@sarah11918
Copy link
Member

Thank you for this contribution, @boutell ! I hope we will get this guide helping people use Apostrophe with Astro before the new year! 🚀

It would help, though, if you first reviewed the style and structure of our other CMS guides. While there is some variation, most guides at least start with a standard set of headings to set the reader up for success, including headings and clear, direct guidance regarding Prerequisites, Adding credentials etc. You will see that our structure generally follows actions the reader will have to complete, in order, and not nouns like "the starter project".

Please do review our writing and style guide, as right now much of this doesn't match our existing documentation. You will find our style, including verb tense, how to address the reader and how to focus on clear, direct instructions documented here: https://contribute.docs.astro.build/guides/writing-style/#writing-style

This is important for several reasons including having documentation that is straightforward to translate. If you're ever in doubt, consider someone needing to translate this and ask yourself whether phrases, or even entire sentences are necessary to guide someone through installing and using your project. (e.g. "Hang on, don't go there yet! We'll get there!" kind of meta-commentary is extra content to translate, extra content to read, and is even sometimes is a sign that maybe steps should in fact be put in a different order so that the instructions follow a logical linear pattern.)

Since you are the expert in how to set up and use Apostrophe with Astro, not me, it's helpful if you could take a pass at trying to match our existing guides first before I do my editing pass (where I might lose some important information or nuance, or have questions as I'm rewriting to match our existing style and structure). I think this will be easier on both of us to have you do a pass first, where you can be sure you're giving the most important information in our more direct, structured style. Then, I can just check for some final polish!

Thank you, and I look forward to having another CMS guide for Astro users in our docs!

@boutell
Copy link
Contributor Author

boutell commented Dec 27, 2023 via email

@sarah11918
Copy link
Member

Hi @boutell ! Just wondering whether you still wanted to take another pass at this, or, now that we're back after the holidays running at full speed, would you like Team Docs to do some work on this with our suggestions to help get this moving?

@boutell
Copy link
Contributor Author

boutell commented Jan 8, 2024 via email

@sarah11918
Copy link
Member

Hey Tim! No one says we can't do both! 😄

You can immediately make a tiny "stub" page, with not much content at all and include a link to the Apostrophe documentation. This gets the page in there right away, and allows people to find it, and the guide already written.

Then, later, the page can be updated in a subsequent PR more leisurely, and we can decide if it makes sense to have content here (which I'm happy to have!) and we can discuss what that could/should look like based on what exists elsewhere.

Here are some very minimal examples you could use as a model that would be very easy to merge in quickly:

You'll see the bar can be quite low! 😄 Let me know what you think!

@boutell
Copy link
Contributor Author

boutell commented Jan 16, 2024 via email

@boutell
Copy link
Contributor Author

boutell commented Jan 16, 2024 via email

@boutell
Copy link
Contributor Author

boutell commented Jan 16, 2024

I have updated this PR to be a properly stubby stub, please review 🙏 Thank you!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 17, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @boutell ! Thanks so much for this, and you're welcome to improve this page over time, as you like!

Welcome to Team Docs! 🥳

src/content/docs/en/guides/cms/apostrophecms.mdx Outdated Show resolved Hide resolved
@boutell
Copy link
Contributor Author

boutell commented Jan 17, 2024

So you've approved it, but your localization team has next crack, and of course as a non-owner I don't do the merging... so I'll be standing by, making 🍿 🙏

@sarah11918
Copy link
Member

Hahah, yup, the "merge queue" label makes it fair game for merging for whoever is next around/available to merge... which would be... me! now! pop that popcorn...

@sarah11918 sarah11918 merged commit b3333f1 into withastro:main Jan 17, 2024
7 checks passed
@boutell
Copy link
Contributor Author

boutell commented Jan 17, 2024 via email

ematipico pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants