-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note non-standard behavior of view transitions for forms set to post #5828
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Good catch! I agree this non standard behavior should be documented Anyone can see the behavior in the console logs when submitting the forms here: |
@OliverSpeir Cool Page! 👍🏼
You might want to add
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
correct in content, can't comment on wording ;-)
The "future" release was 4.0.7 |
I've updated the PR description to match. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this, @knpwrs !
I will just need us to confirm the case of POST
(I suspect it should be all caps?), and I streamlined the wording a little bit to match our concise tone in docs (and have fewer words for our translators to wrangle). See what you think of the suggestion, and whether it still captures the proper nuance. Then we'll get this into docs right away! 🙌
Co-authored-by: Sarah Rainsberger <[email protected]>
@sarah11918 I think that's for exported API route handlers, not for form method verbs. EDIT: I say that because the browser doesn't care, whereas I know Astro supports exporting verb handlers. |
Gotcha. If it is a stylistic choice, it probably makes sense for us to converge with all caps, just for consistency and having one nice rule for contributors! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now, thank you so much and welcome to Team Docs! 🥳
…5828) Co-authored-by: Sarah Rainsberger <[email protected]>
Description (required)
This PR adds a note about the non-standard behavior of Astro view transitions for forms with
method
set topost
.Related issues & labels (optional)
For Astro release:
4.0.7
. See astro [#9466](PR withastro/astro#9466).