Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update integration documentation #5306

Merged
merged 2 commits into from
Nov 30, 2023
Merged

feat: update integration documentation #5306

merged 2 commits into from
Nov 30, 2023

Conversation

nerdoza
Copy link
Contributor

@nerdoza nerdoza commented Nov 7, 2023

Description (required)

Updates integration reference document with new updateConfig method types.

Related issues & labels (optional)

Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f2bab84
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/654a910e648e620007df028b
😎 Deploy Preview https://deploy-preview-5306--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Updates integration reference document with new `updateConfig` method types.

Related to (Astro PR 9013)[withastro/astro#9013]
Copy link
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Nov 8, 2023
Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am the one who asked for those changes and I think they're right, but an approval for someone more used to the codebase would be great

@sarah11918
Copy link
Member

This PR depends on an PR from core merging first! If that PR is accepted, then I think this one should be fine to document it!

@nerdoza
Copy link
Contributor Author

nerdoza commented Nov 30, 2023

@sarah11918, dependent PR was merged as part of Astro v4.

@sarah11918
Copy link
Member

@bayssmekanique Thanks for the ping! Will get this in today!

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 30, 2023 4:32pm

@sarah11918 sarah11918 merged commit 0151b93 into withastro:main Nov 30, 2023
7 checks passed
@nerdoza nerdoza deleted the feat/update-config-update branch November 30, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants