Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for shikiji multiple theming #5191

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Update docs for shikiji multiple theming #5191

merged 2 commits into from
Nov 9, 2023

Conversation

horo-fox
Copy link
Contributor

Description (required)

Update documentation with respect to withastro/astro#8903

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 52ba306
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/654d2d93422c990008464435
😎 Deploy Preview https://deploy-preview-5191--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@horo-fox horo-fox changed the title Update docs for https://github.com/withastro/astro/pull/8903 Update docs for shikiji multiple theming Oct 24, 2023
Copy link
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Oct 25, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @horo-fox ! I've added the label to make sure this doesn't merge before the feature does! 🙌

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Nov 5, 2023
@sarah11918
Copy link
Member

Leaving a comment to update bot status

@@ -589,6 +589,12 @@ export default defineConfig({
// Choose from Shiki's built-in themes (or add your own)
// https://github.com/shikijs/shiki/blob/main/docs/themes.md
theme: 'dracula',
// Alternatively, provide multiple themes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commenting just for bot status update! All is good!

@sarah11918 sarah11918 merged commit 2f43346 into withastro:main Nov 9, 2023
9 checks passed
@horo-fox horo-fox deleted the light-dark-theming branch November 10, 2023 15:33
MoustaphaDev added a commit that referenced this pull request Nov 13, 2023
…-reference.mdx (#5367)

* i18n(fr) Update markdown-content.mdx

Update and fix old translation and #5031 #5300 #5191

* Update markdown-content.mdx

Fix link L100

* Fix Link Reading time L519

* Add reading-time.mdx

* Add reading-time.mdx

Add french translate for fix link error

* Fix link

* Fix recipe link reading time markdown-content.mdx

* Fix link recipe reading time

* Update markdown-content.mdx

* Create reading-time.mdx

Fix blnk into name folder recipes

* Delete src/content/docs/fr/recipes  directory

* Update cli-reference.mdx

Add translation of cli-reference file

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Thomas Bnt <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Thomas Bnt <[email protected]>

* Update src/content/docs/fr/recipes/reading-time.mdx

Co-authored-by: Thomas Bnt <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Co-authored-by: Thomas Bnt <[email protected]>

* Update src/content/docs/fr/reference/cli-reference.mdx

Je pense que tu as raison

Co-authored-by: Thomas Bnt <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Oh bien vue merci

Co-authored-by: Happydev <[email protected]>

* Update src/content/docs/fr/guides/markdown-content.mdx

Merci

Co-authored-by: Happydev <[email protected]>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Happydev <[email protected]>

* Update src/content/docs/fr/reference/cli-reference.mdx

Co-authored-by: Happydev <[email protected]>

* Update src/content/docs/fr/recipes/reading-time.mdx

Co-authored-by: Happydev <[email protected]>

---------

Co-authored-by: Thomas Bnt <[email protected]>
Co-authored-by: Happydev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants