Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guides: update gitlab #5130

Merged
merged 2 commits into from
Nov 5, 2023
Merged

guides: update gitlab #5130

merged 2 commits into from
Nov 5, 2023

Conversation

dreyfus92
Copy link
Member

Description (required)

After trying to help a fellow member from Discord deploy their website with GitLab Pages, I conducted some research and found our documentation to be outdated. Therefore, I decided to improve the deployment guide to bring it up to date. Let me know what you guys think.

Related issues & labels (optional)

  • Suggested label: improve documentation

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4a320c1
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/65478da87a7d2b000870c8ac
😎 Deploy Preview https://deploy-preview-5130--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @dreyfus92!

@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label Oct 20, 2023
@sarah11918
Copy link
Member

Thanks for this @dreyfus92 ! I'm adding the labels help wanted and confirm behaviour because this seems like quite a few changes from the original, so it would be nice to have others walk through the steps and confirm, too!

@sarah11918 sarah11918 added help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. help wanted Issues looking for someone to run with them! labels Oct 21, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really well written @dreyfus92 , and we haven't had anyone to check the new instructions, but we trust you as one of our top Team Docs members, so let's get this meeeeerged! 🚀

@sarah11918 sarah11918 merged commit 161226d into withastro:main Nov 5, 2023
9 checks passed
@dreyfus92 dreyfus92 deleted the updates-165 branch January 9, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help - confirm behaviour Walk through the example/issue and confirm this is a general behaviour, or a correct update to make. help wanted Issues looking for someone to run with them! improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants