Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18nIgnore] i18n(zh-cn): delete DontEditWarning & Video #4841

Merged
merged 3 commits into from
Sep 28, 2023

Conversation

liruifengv
Copy link
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content

Description

  • delete DontEditWarning & Video

Related Issue / Implementation PR

  • Closes Issue #

@netlify
Copy link

netlify bot commented Sep 28, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bce5605
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6515653c9189e90008806856
😎 Deploy Preview https://deploy-preview-4841--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 28, 2023
@liruifengv
Copy link
Member Author

Wait #4821 merged

@Genteure
Copy link
Contributor

Should this be marked as [i18nIgnore]?

@liruifengv
Copy link
Member Author

Should this be marked as [i18nIgnore]?

不用,改中文不会对其他产生影响

@Genteure
Copy link
Contributor

But it would affect the i18n tracker and mark these pages as up to date. It wouldn't matter if all the pages edited is already up to date anyways, but you never know what might get merged into the English main before this PR gets merged.

@liruifengv liruifengv changed the title i18n(zh-cn): delete DontEditWarning & Video [i18nIgnore] i18n(zh-cn): delete DontEditWarning & Video Sep 28, 2023
@liruifengv
Copy link
Member Author

But it would affect the i18n tracker and mark these pages as up to date. It wouldn't matter if all the pages edited is already up to date anyways, but you never know what might get merged into the English main before this PR gets merged.

Done

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yanthomasdev yanthomasdev merged commit 3819daf into withastro:main Sep 28, 2023
@liruifengv liruifengv deleted the fix-errors branch September 28, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants