chore(en): describe more accepted class:list value kinds
#3829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
Love this, @duanwilliam! Thanks so much for this addition, and welcome to Team Docs! 🥳
sarah11918
added
the
improve or update documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Currently, the documentation on
class:listdoesn't mention anything about how it handles false values.This was an issue when it stringified
false, diverging in behavior from theclsxpackage the documentation references (withastro/astro#3920);while that since has since been fixed (withastro/astro#3922), there's still no mention of how it handles such values in the documentation. This PR adds a note of how it handles
false(as well asnull) in the docs, as observed in the source code at https://github.com/withastro/astro/blob/main/packages/astro/src/runtime/server/util.ts#L19.