Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new APIs for middleware #3632

Merged
merged 5 commits into from
Jul 6, 2023
Merged

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented Jun 30, 2023

What kind of changes does this PR include?

  • New or updated content

Description

This PR is part of the work around the vercel edge middleware support.

Here's the final PR that should introduce the feature: withastro/astro#7532

@netlify
Copy link

netlify bot commented Jun 30, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 7a7484a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64a6dfd4646dde0008ee0d85
😎 Deploy Preview https://deploy-preview-3632--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ematipico ematipico added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Jun 30, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the links for the link checker, and just a couple of tidying syntax things, but this looks great @ematipico! Approving with the changes below.

src/content/docs/en/guides/middleware.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/middleware.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/middleware.mdx Outdated Show resolved Hide resolved
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jul 5, 2023
@sarah11918 sarah11918 changed the base branch from main to next-release July 6, 2023 10:58
@sarah11918 sarah11918 changed the base branch from next-release to main July 6, 2023 11:03
@sarah11918 sarah11918 changed the base branch from main to 2-8-0 July 6, 2023 11:11
@sarah11918 sarah11918 changed the base branch from 2-8-0 to main July 6, 2023 11:20
@sarah11918 sarah11918 merged commit e52561d into main Jul 6, 2023
@sarah11918 sarah11918 deleted the feat/middleware-new-apis-plt-578 branch July 6, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants