Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to MDX 0.17 #2750

Merged
merged 1 commit into from
Feb 27, 2023
Merged

chore: bump to MDX 0.17 #2750

merged 1 commit into from
Feb 27, 2023

Conversation

bholmesdev
Copy link
Contributor

What kind of changes does this PR include?

  • Changes to the docs site code

Description

  • The @astrojs/markdoc PR (@astrojs/markdoc astro#6209) includes changes to the MDX internals. Since docs is on an older version of MDX, our smoke tests aren't able to resolve versions correctly. This should fix us!

@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63fd17317088ce1957b5779a
😎 Deploy Preview https://deploy-preview-2750--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@delucis
Copy link
Member

delucis commented Feb 27, 2023

Looks like the Netlify preview failure was just flakiness on their end. Redeploying now! https://app.netlify.com/sites/astro-docs-2/deploys/63fd17317088ce1957b5779a

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will be fine but let’s wait for the Netlify deploy to complete just to be safe!

@delucis
Copy link
Member

delucis commented Feb 27, 2023

Rebuild worked fine! 👍

Won’t update the status checks here but this is good to merge 🚀

@bholmesdev bholmesdev merged commit 96799be into main Feb 27, 2023
@bholmesdev bholmesdev deleted the bump-mdx branch February 27, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants