Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(es): astro-components update #1429

Merged
merged 2 commits into from
Aug 29, 2022
Merged

i18n(es): astro-components update #1429

merged 2 commits into from
Aug 29, 2022

Conversation

glopzel
Copy link
Contributor

@glopzel glopzel commented Aug 29, 2022

added note on dynamic vs reactive values

What kind of changes does this PR include?

  • New or updated content
  • Translated content

Description

  • Update Astro Components (JSX-like Expressions section) with a note on dynamic vs reactive values

added note on dynamic vs reactive values
@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2d8640f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/630d124dea456a0008592ef1
😎 Deploy Preview https://deploy-preview-1429--astro-docs-2.netlify.app/es/core-concepts/astro-components
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 29, 2022
Copy link
Contributor

@fredoist fredoist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @glopzel 👍🏼

@yanthomasdev
Copy link
Member

yanthomasdev commented Aug 29, 2022

Hey @glopzel, thanks for the amazing contribution! Welcome to our Docs Face Pile! 💜
Also, thank you @fredoist 🙌

OBS: We like to welcome first-time contributors with a pun in our Discord (#docs channel) and we sure would love to have you there as well! https://astro.build/chat

EDIT: I have added a small code sample fix, since it's a very small change I have added it as part of this PR, so we can merge and be sure we are 100% up-to-date with the English docs.

@yanthomasdev yanthomasdev merged commit fa92cd2 into withastro:main Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants