Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mention about script processing behavior in JSX expression #10656

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Jan 8, 2025

Description (required)

Since renderScript was turned on by default in Astro 5, rules of processing scripts are consistent, regardless of the context the script is written in.

I added an example to show what it unlocks (todo)

Related issues & labels (optional)

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 8, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/client-side-scripts.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v5.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit e2d4226
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/678166e4d57281000807edd4
😎 Deploy Preview https://deploy-preview-10656--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Jan 8, 2025
@sarah11918
Copy link
Member

Thanks for the update!

Also a related comment here re: what we might need in the compiler PR! withastro/compiler#1057 (comment)

@MoustaphaDev MoustaphaDev marked this pull request as ready for review January 10, 2025 16:14
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reordered some stuff on the upgrade guide to fit the structure and directly committed, but otherwise, ready to go when the feature PR is released! Thanks for such clear advice! 🎉

Co-authored-by: Armand Philippot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants