-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mention about script processing behavior in JSX expression #10656
base: main
Are you sure you want to change the base?
Conversation
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thanks for the update! Also a related comment here re: what we might need in the compiler PR! withastro/compiler#1057 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just reordered some stuff on the upgrade guide to fit the structure and directly committed, but otherwise, ready to go when the feature PR is released! Thanks for such clear advice! 🎉
Co-authored-by: Armand Philippot <[email protected]>
Description (required)
Since
renderScript
was turned on by default in Astro 5, rules of processing scripts are consistent, regardless of the context the script is written in.I added an example to show what it unlocks (todo)
Related issues & labels (optional)
RenderScript
is enabled compiler#1057