Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize dependencies #10493

Merged
merged 21 commits into from
Dec 20, 2024
Merged

Modernize dependencies #10493

merged 21 commits into from
Dec 20, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented Dec 20, 2024

Description (required)

Updates various docs dependencies that are getting a bit dusty including removing some (like node-fetch that are no longer needed at all).

Dependency changes

Removed
  • node-fetch (no longer needed in newer Node versions)
  • eslint-plugin-react (we don’t have any JSX to lint)
  • remark-directive (not used directly anymore — was used for asides but that’s now handled by Starlight)
Major
  • @11ty/eleventy-fetch: 3.0.0 => 5.0.1 (removes node-fetch under the hood)
  • @types/node: 18.6.4 => 20.17.10 (we’re running on Node 20 everywhere now)
  • eslint: 8.29.0 => 9.17.0 (switched to the newer “flat” config format)
    • @typescript-eslint/eslint-plugin was removed in favour of typescript-eslint
    • @typescript-eslint/parser: 5.46.1 => 8.18.1
    • astro-eslint-parser: 0.16.0 => 1.1.0
    • eslint-plugin-astro: 0.21.0 => 1.3.1
    • Added: @eslint/js and globals
  • domhandler: 4.3.1 => 5.0.3 (types for htmlparser2)
  • htmlparser2: 7.2.0 => 9.1.0 (used for DOM parsing in link checker CI, required a tweak to import style as they changed package format)
  • p-retry: 5.1.1 => 6.2.1 (used for our cached fetches, v6 only dropped old Node version support)
  • sharp: 0.32.6 => 0.33.5
Minor

pnpm itself: 9.3.0 => 9.15.1

  • @actions/core: 1.9.0 => 1.11.1 (used in link checker CI and Tuesday translation bot)
  • @docsearch/css & @docsearch/js: 3.5.1 => 3.8.2
  • fast-glob: 3.2.11 => 3.3.2
  • prettier: 3.3.3 => 3.4.2
  • typescript: 5.0.2 => 5.6.2 (required a few minor tweaks to get type checks passing)

Other changes

  • Removed two script utilities we no longer use (pre-Lunarian relics)

Not updated

  • canvas-confetti — recent releases add new features we don’t need and increase bundle size
  • remark-smartypants — causes type errors for some reason, didn’t investigate why

@delucis delucis added the site improvement Some thing that improves the website functionality - ask @delucis for help! label Dec 20, 2024
Copy link

netlify bot commented Dec 20, 2024

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 6574394
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6765f6f77516e40008bf1e3a
😎 Deploy Preview https://deploy-preview-10493--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@delucis delucis marked this pull request as ready for review December 20, 2024 20:50
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me and seems to be working as expected locally through the CLI and Visual Studio Code (only tested these 2). Only left a small comment to potentially remove a little bit more config.

eslint.config.mjs Outdated Show resolved Hide resolved
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the deploy preview with all of the usual suspects!

@delucis delucis merged commit 56fd5b5 into main Dec 20, 2024
10 checks passed
@delucis delucis deleted the chris/modernize branch December 20, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants