docs: Add information about dynamic static split server islands #10106
Conversation
❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →Built without sensitive environment variables
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
There was a problem hiding this comment.
Hi @Jacob-Roberts , thanks for submitting documentation for your feature! 🚀
I took a look at the initial PR, and I haven't seen the code approved yet, and docs can never be edited before we know that the feature is complete and approved anyway, in case some details or implementation change during the code review process. So just letting you know this will have to sit and wait on the feature being accepted. (And, it's possible being so close to a v5 release that there may not yet be another beta release, in which case I don't know whether devs would accept a new feature without being able to at least release it in a beta first? Just a heads up on that, too! This is cutting it SUPER close for comfort! But, I'll wait and see what happens there!)
In the mean time, I've left a comment about needing an example though!
| This hook gives you the opportunity to add private config options that are exposed only to integrations. | ||
| There are certain options that are not directly exposed to users, but are allowed to be written from integrations. | ||
|
|
||
| For example, the astro config [`serverIslandDynamicBase`](https://github.com/withastro/astro/blob/30d720f519f991720ee0b7c328a4bf4bbf31760d/packages/astro/src/types/public/config.ts#L1979-L1986) |
There was a problem hiding this comment.
Heads up that we do not typically link to code outside of docs. Everything in docs should be fully explained so people don't have to leave the page. A full example would have to be provided here.
sarah11918
added
add new content
|
Noting that this PR was auto closed when v5 docs updated. We will need a new docs PR for this! @Jacob-Roberts , could you please look at my comments here and create a new PR? |
|
Ooh, it's not letting me reopen because the beta branch no longer exists... so that's why we need a new PR! |
|
Thanks @sarah11918! I'll submit a new PR. Moved to #10194 |
Description (required)
This PR is the documentation follow-on to this PR which adds the ability to serve the server islands from a separate domain.
For Astro version:
5.0. See astro PR 12320.First-time contributor to Astro Docs?
jake_roberts