-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revive recipes #9900
revive recipes #9900
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
All looks good to me, but need a place in the sidebar or to otherwise link to this! Now the haunted mystery page has content, but can't be accessed! |
Ah indeed, in the next version (your sidebar experiment) it would be simpler to put it in the sidebar I think but there... Maybe:
But... This idea assumes that Otherwise, maybe we can add For the moment I don't see any other alternatives. It doesn't seem to me that a link to |
Thanks for the review @ArmandPhilippot ! As we discussed on the call, we may be doing away with all of this content except official recipes in the new design! (Sooner?) I think we are leaning towards we don't need to be people's search engines, although it's fair that if we can help some people, the content may not be harmful. (That said, we don't regularly review and update, so it may give more weight than we intend.) To fix the immediate problem, which is that a page at But we then have the problem of "OK, but people need to be able to find the recipe content" so we need SOME place in the sidebar for it now! 😅 |
Co-authored-by: Armand Philippot <[email protected]>
One last point that requires confirmation since I'm not familiar enough with how Starlight works: If I visit a recipe in the Netlify preview, both "How-to Recipes" and "Community Resources" links are highlighted. Is this due to the redirect being still "active" in the preview or is there something else to fix? I expect to see only "How-to Recipes" highlighted. Other than that, LGTM! But I guess you're waiting for other opinions. 😅 |
Converting to draft while I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Glad we are fixing the weird placeholder page even if all of this goes away with the v5 docs 🙌
Signed-off-by: Thomas Bonnet <[email protected]>
Signed-off-by: Thomas Bonnet <[email protected]> Co-authored-by: Yan <[email protected]> Co-authored-by: ArmandPhilippot <[email protected]>
See #9900 Co-authored-by: Yan <[email protected]> Co-authored-by: thomasbnt <[email protected]>
See #9900 and #9888 Co-authored-by: Yan <[email protected]> Co-authored-by: thomasbnt <[email protected]>
Description (required)
This page addresses the issue where we have a hidden/unused
en/recipes/
page because this page DOES exist in other languages.TRANSLATORS: This PR revergs the English
recipes.mdx
to match the (never updated) translations, so it's possible that existing translations may not need to updaterecipes.mdx
at all. Use your judgement, and if your existing page is "close enough", you can assume the content is fine! You can make a trivial commit to update the status of your page to "updated" if needed.This PR also removes the
talks.mdx
page as it was more of a maintenance burden than helpful.Quick fix for haunted recipe page