Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: [AST] head element inside slot is removed #531

Closed
Princesseuh opened this issue Sep 29, 2022 · 0 comments · Fixed by #540
Closed

🐛 BUG: [AST] head element inside slot is removed #531

Princesseuh opened this issue Sep 29, 2022 · 0 comments · Fixed by #540

Comments

@Princesseuh
Copy link
Member

Princesseuh commented Sep 29, 2022 •
edited
Loading

What version of @astrojs/compiler are you using?

0.23.4

What package manager are you using?

pnpm

What operating system are you using?

macOS

Describe the Bug

The following code AST does not include the head element:

<slot>
   <head>hello</head>
</slot>

This cause our Prettier plugin to create the following result:

<slot />hello

Link to Minimal Reproducible Example

See bug description
This was referenced Sep 29, 2022
Closed
Closed
natemoo-re added a commit that referenced this issue Oct 4, 2022
@natemoo-re
fix(#531): handle slots before <head>
f6390ce
@natemoo-re natemoo-re mentioned this issue Oct 4, 2022
Merged
natemoo-re added a commit that referenced this issue Oct 5, 2022
@natemoo-re
Handle slot before <head> (#540)
8ee78a6 
* fix(#531): handle slots before <head>

* chore: add changeset

* chore: update test

Co-authored-by: Nate Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle slot before <head> withastro/compiler
1 participant
@Princesseuh