Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new test cases for non-UTF-8 and space file names #9947

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add new test cases for non-UTF-8 and space file names #9947

merged 1 commit into from
Feb 2, 2024

Conversation

ktym4a
Copy link
Contributor

@ktym4a ktym4a commented Feb 2, 2024

Changes

Add testcases for #9934 and #9945

Testing

Tests should pass!

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2024

⚠️ No Changeset found

Latest commit: 1482b92

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 2, 2024
ematipico
ematipico approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you!

@ematipico ematipico merged commit cd67dd0 into withastro:main Feb 2, 2024
13 checks passed
@ktym4a ktym4a deleted the chore/add-dev-server-test branch February 2, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktym4a @ematipico