-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes false positives in the dev overlay audit when multiple role
values exist.
#9857
Conversation
🦋 Changeset detectedLatest commit: dd1de37 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hmm, I think it would be better to fix the destructuring code here. I also think getRole should actually properly process multiple roles instead of choosing just the first one. |
Okay, indeed I also think there should be restoration where deconstructed. But I may not be sure how to handle multiple roles correctly. |
c4afdef
to
8b2686c
Compare
@Princesseuh I tried it again, please help me correct it. Thanks! |
packages/astro/src/runtime/client/dev-toolbar/apps/audit/a11y.ts
Outdated
Show resolved
Hide resolved
…, when multiple roles exist, check each role. fix withastro#9856
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
role
values exist.
When multiple values are set in the role, only the first value is returned.
fix #9856
Changes
When multiple roles exist, check each role. Fixing the issue of errors caused by multiple values in the role. #9856
Testing
Docs