Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes false positives in the dev overlay audit when multiple role values exist. #9857

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

iamyunsin
Copy link
Contributor

@iamyunsin iamyunsin commented Jan 29, 2024

When multiple values are set in the role, only the first value is returned.

fix #9856

Changes

When multiple roles exist, check each role. Fixing the issue of errors caused by multiple values in the role. #9856

Testing

  • No need to test, as this change will not affect the original behavior.

Docs

  • Only modified the way the role is valued, compatible with the situation of multiple role values.

Copy link

changeset-bot bot commented Jan 29, 2024

🦋 Changeset detected

Latest commit: dd1de37

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 29, 2024
@Princesseuh
Copy link
Member

Princesseuh commented Jan 29, 2024

Hmm, I think it would be better to fix the destructuring code here. I also think getRole should actually properly process multiple roles instead of choosing just the first one.

@iamyunsin
Copy link
Contributor Author

Hmm, I think it would be better to fix the destructuring code here. I also think getRole should actually properly process multiple roles instead of choosing just the first one.

Okay, indeed I also think there should be restoration where deconstructed. But I may not be sure how to handle multiple roles correctly.

@iamyunsin iamyunsin force-pushed the main branch 2 times, most recently from c4afdef to 8b2686c Compare January 30, 2024 01:50
@iamyunsin
Copy link
Contributor Author

Hmm, I think it would be better to fix the destructuring code here. I also think getRole should actually properly process multiple roles instead of choosing just the first one.

@Princesseuh I tried it again, please help me correct it. Thanks!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

.changeset/eight-flowers-remain.md Outdated Show resolved Hide resolved
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@natemoo-re natemoo-re changed the title fix: fixing the issue of errors caused by multiple values in the role. Fixes false positives in the dev overlay audit when multiple role values exist. Feb 13, 2024
@natemoo-re natemoo-re merged commit 73bd900 into withastro:main Feb 13, 2024
13 of 14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When I use astro-diagram to render the mermaid sequence diagram, in developer mode, an error is reported!
4 participants