Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused prop in blog template #9848

Merged
merged 2 commits into from
Jan 29, 2024
Merged

remove unused prop in blog template #9848

merged 2 commits into from
Jan 29, 2024

Conversation

kandros
Copy link
Contributor

@kandros kandros commented Jan 27, 2024

Changes

remove unused prop in Header component of blog template, the SITE_TITLE is already imported and used within

Testing

Manually by using the template

Docs

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b41cc64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: example Related to an example package (scope) pkg: astro Related to the core `astro` package (scope) labels Jan 27, 2024
bluwy
bluwy reviewed Jan 29, 2024
View reviewed changes
packages/astro/test/units/dev/dev.test.js Outdated Show resolved Hide resolved
packages/astro/test/units/dev/dev.test.js Outdated Show resolved Hide resolved
examples/blog/src/pages/index.astro Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the pkg: astro Related to the core `astro` package (scope) label Jan 29, 2024
@bluwy bluwy merged commit f27f790 into withastro:main Jan 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kandros @bluwy