-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(toolbar): Fix loading third-party apps using absolute paths #9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 173f083 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks good! Can we make a preview release to test it out? I don't remember the command |
bluwy
reviewed
Jan 26, 2024
packages/astro/src/vite-plugin-dev-toolbar/vite-plugin-dev-toolbar.ts
Outdated
Show resolved
Hide resolved
!preview toolbar-absolute-paths |
bluwy
approved these changes
Jan 26, 2024
ematipico
approved these changes
Jan 26, 2024
Snapshots have been released for the following packages:
Publish Log
Build Log
|
natemoo-re
approved these changes
Jan 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bring back the fix for absolute paths for dev toolbar apps that was removed by accident in my error handling PR.
Fix #9824
Testing
Added a test, I think it cover the use case? Not sure with the monorepo
Docs
N/A