-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regression on dynamic sibling trees and index inside rest parameter folders #9786
Fix regression on dynamic sibling trees and index inside rest parameter folders #9786
Conversation
🦋 Changeset detectedLatest commit: 4a1df84 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Since this is a soft subject, I believe we should be clear as much as we can. I think it's valuable to add more clarification in our docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the change is good! Just added feedback around adding more cases. After that, we can merge it and ship it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Changes
[...rest]/index.astro
) take precedence overindex.astro
in 4.2.1 #9770Testing
The new test includes a nested structure of dynamic parameters as folders with indexes, including rest parameters in the middle of the route.
Docs
The rules remain the same but now apply per-segment instead of the whole route at once.
Unclear to me whether this needs to be made more clear on the docs.