Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression on dynamic sibling trees and index inside rest parameter folders #9786

Merged
merged 9 commits into from
Jan 24, 2024

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Jan 23, 2024

Changes

Testing

The new test includes a nested structure of dynamic parameters as folders with indexes, including rest parameters in the middle of the route.

Docs

The rules remain the same but now apply per-segment instead of the whole route at once.
Unclear to me whether this needs to be made more clear on the docs.

Copy link

changeset-bot bot commented Jan 23, 2024

🦋 Changeset detected

Latest commit: 4a1df84

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 23, 2024
@ematipico
Copy link
Member

Unclear to me whether this needs to be made more clear on the docs.

Since this is a soft subject, I believe we should be clear as much as we can. I think it's valuable to add more clarification in our docs

@Fryuni Fryuni marked this pull request as draft January 23, 2024 15:01
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change is good! Just added feedback around adding more cases. After that, we can merge it and ship it

@Fryuni Fryuni marked this pull request as ready for review January 23, 2024 17:14
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

.changeset/six-shrimps-glow.md Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 5b29550 into withastro:main Jan 24, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 24, 2024
@Fryuni Fryuni deleted the fix/dynamic-routes-regression branch January 24, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
4 participants