Fix @astrojs/markdown-remark
bundling for non-node runtimes
#9736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This will help with withastro/adapters#110 (not a complete fix yet)
For some reason, Rollup sees this:
astro/packages/markdown/remark/src/load-plugins.ts
Line 6 in ea6cbd0
As side-effectful, so it'll include the import to
pathToFileUrl
in the final bundle, which wouldn't work for Cloudflare builds.This PR side-steps by initializing the
cwdUrlStr
variable lazily, which is also better for perf.Testing
I didn't add a test because it's hard to create a failing test without a very specific build of Astro.
Docs
n/a. internal change.