Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @astrojs/markdown-remark bundling for non-node runtimes #9736

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jan 19, 2024

Changes

This will help with withastro/adapters#110 (not a complete fix yet)

For some reason, Rollup sees this:

const cwdUrlStr = pathToFileURL(path.join(process.cwd(), 'package.json')).toString();

As side-effectful, so it'll include the import to pathToFileUrl in the final bundle, which wouldn't work for Cloudflare builds.

This PR side-steps by initializing the cwdUrlStr variable lazily, which is also better for perf.

Testing

I didn't add a test because it's hard to create a failing test without a very specific build of Astro.

Docs

n/a. internal change.

Copy link

changeset-bot bot commented Jan 19, 2024

🦋 Changeset detected

Latest commit: a942123

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Jan 19, 2024
@bluwy bluwy merged commit 53c69dc into main Jan 19, 2024
13 checks passed
@bluwy bluwy deleted the markdown-remark-fix branch January 19, 2024 14:38
@astrobot-houston astrobot-houston mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants