Refactor style-only HMR cache and performance #9712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cace49b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
ematipico
reviewed
Jan 17, 2024
matthewp
approved these changes
Jan 17, 2024
natemoo-re
reviewed
Jan 17, 2024
Co-authored-by: Nate Moore <[email protected]>
ematipico
approved these changes
Jan 18, 2024
natemoo-re
approved these changes
Jan 18, 2024
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Supersedes and closes #9356
This PR changes how we detect if only the styles are changed in an Astro file, so we can only apply HMR on those styles. In contrary to #9356, this uses regexes to perform the comparisons, which is technically a bit brittle, but I think covers a fair amount of cases enough that it's worth the perf gain.
It also simplifies our caching, so it's less about caching but more of recording additional metadata from the compilation result. This way we use lesser data and memory, and avoid unintentional invalidation causing scripts and styles virtual modules to fail.
@natemoo-re Would love your thoughts on the regex approach for style-change detection. I'm happy to refactor that to something else if anyone doesn't feel comfortable about it 😄
Testing
The existing tests should pass as it's a refactor.
Docs
n/a. internal refactor.