Opt-out ViewTransition for cross-origin form.

[kidylee]

For issue #9676 ViewTransition doesn't respect form method="post" when the action of form targets external URL

Leaving the submit handler when the form is cross-origin.

Edited:
Closes #9676

[changeset-bot]

🦋 Changeset detected

Latest commit: fa89bfd

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[martrapp]

Hello @kidylee! Thank you for your PR!

While your change is very clean, robust and understandable, I would like to ask you for a more compact implementation. We are a bit concerned about the code size of the ViewTransition.astro and would like to keep it rather small.

[kidylee]

Hello @kidylee! Thank you for your PR!

While your change is very clean, robust and understandable, I would like to ask you for a more compact implementation. We are a bit concerned about the code size of the ViewTransition.astro and would like to keep it rather small.

Thanks for your patiently guidance, I have made it inline and follow the same pattern of link logic does: composing return conditions in a single if, hopefully it is a good practice.

if (method === 'dialog' || location.origin !== new URL(action, location.href).origin)

[martrapp]

Looks good!
Many thanks for this improvement!