fix(i18n): emit an error when the index isn't found #9678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 00c9fb5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
sarah11918
approved these changes
Jan 12, 2024
There was a problem hiding this comment.
Docs is happy with the error message! (c @Princesseuh to confirm the syntax/formatting!)
Co-authored-by: Sarah Rainsberger <[email protected]>
MoustaphaDev
approved these changes
Jan 12, 2024
Co-authored-by: Florian Lefebvre <[email protected]>
Merged
ematipico
added a commit
that referenced
this pull request
Jan 12, 2024
* fix(i18n): emit an error when the index isn't found * changeset * Update .changeset/proud-guests-bake.md Co-authored-by: Sarah Rainsberger <[email protected]> * rename * Update packages/astro/src/core/errors/errors-data.ts Co-authored-by: Florian Lefebvre <[email protected]> --------- Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]>
ematipico
added a commit
that referenced
this pull request
Jan 17, 2024
* feat(i18n): disable redirect * feat(i18n): add option to disable redirect to default language * chore: add schema validation * docs * changeset * Update packages/astro/src/core/config/schema.ts Co-authored-by: Bjorn Lu <[email protected]> * chore: address feedback * fix test * Update .changeset/cyan-grapes-suffer.md Co-authored-by: Sarah Rainsberger <[email protected]> * Update packages/astro/src/@types/astro.ts Co-authored-by: Sarah Rainsberger <[email protected]> * Fix discord fetch code (#9663) * Force re-execution of Partytown's head snippet on view transitions (#9666) * Remove the header script before a view transition takes place to force a reload on the next page * Add changeset * Save another char * [ci] format * fix(assets): Implement all hooks in the passthrough image service (#9668) * fix(assets): Implement all hooks in the passthrough image service * chore: changeset * refactor(toolbar): Rename every internal reference of overlay/plugins to toolbar/apps (#9647) * refactor(toolbar): Rename every internal reference of overlay/plugins to toolbar/apps * refactor: rename vite plugin * fix: update import * nit: add setting fallback * Disable file watcher for internal one-off vite servers (#9665) * Use node:test and node:assert/strict (#9649) * [ci] format * fix(i18n): emit an error when the index isn't found (#9678) * fix(i18n): emit an error when the index isn't found * changeset * Update .changeset/proud-guests-bake.md Co-authored-by: Sarah Rainsberger <[email protected]> * rename * Update packages/astro/src/core/errors/errors-data.ts Co-authored-by: Florian Lefebvre <[email protected]> --------- Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]> * feat(i18n): add option to disable redirect to default language * chore: rebase * Update packages/astro/src/@types/astro.ts Co-authored-by: Bjorn Lu <[email protected]> * lock file update --------- Co-authored-by: Bjorn Lu <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Martin Trapp <[email protected]> Co-authored-by: Martin Trapp <[email protected]> Co-authored-by: Erika <[email protected]> Co-authored-by: Bjorn Lu <[email protected]> Co-authored-by: Florian Lefebvre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We've had more than one report where users didn't add a index page when they use the option
i18n.routing.prefixDefaultLocaletotrue.The index page is required to create a redirect from
/to/<defaultLocale>.This PR adds a check during the build, and emits an error if the index is missing.
Testing
There was a case where a fixture didn't have the index, and the test cases were still passing.
These fixtures were now raising an error, and I added the index page.
Docs
/cc @withastro/maintainers-docs for feedback!