Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image proxy not working correctly #9659

Merged
merged 7 commits into from
Jan 15, 2024
Merged

fix: image proxy not working correctly #9659

merged 7 commits into from
Jan 15, 2024

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Jan 11, 2024

Changes

Because of fsPath not being enumerable, we lost it a fair amount in certain situations. This PR fixes this without making it public.

Fix #9520

Testing

Added tests for this!

Docs

N/A

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: da04fde

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 11, 2024
@Princesseuh Princesseuh marked this pull request as ready for review January 13, 2024 03:06
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice penguins

@Princesseuh Princesseuh merged commit 39050c6 into main Jan 15, 2024
13 checks passed
@Princesseuh Princesseuh deleted the fix/proxy-crimes branch January 15, 2024 17:17
@astrobot-houston astrobot-houston mentioned this pull request Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build does not generate image file for '?url' import
2 participants