Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: UpdatepossibleConfigFiles #9600

Merged
merged 5 commits into from
Jan 5, 2024
Merged

chore: UpdatepossibleConfigFiles #9600

merged 5 commits into from
Jan 5, 2024

Conversation

jacobdalamb
Copy link
Contributor

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Testing

n/a

Docs

withastro/docs#6093

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 3, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: dfc8cbb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 3, 2024
@jacobdalamb jacobdalamb changed the title Add .ts to list of possibleConfigFiles chore: Update tailwindcsspossibleConfigFiles Jan 3, 2024
@jacobdalamb jacobdalamb changed the title chore: Update tailwindcsspossibleConfigFiles chore: UpdatepossibleConfigFiles Jan 3, 2024
lilnasy
lilnasy approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@lilnasy lilnasy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick context for reviewers, astro add checks whether any one of possibleConfigFiles exists to determine whether to create a fresh one.

@jacobdalamb jacobdalamb mentioned this pull request Jan 4, 2024
Merged
ematipico
ematipico reviewed Jan 4, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A changeset is required here, would it be possible to add one?

@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Jan 4, 2024
@jacobdalamb
Copy link
Contributor Author

A changeset is required here, would it be possible to add one?

Added!

@florian-lefebvre
Update .changeset/many-rules-kick.md
dfc8cbb 
Co-authored-by: Florian Lefebvre <[email protected]>
@ematipico ematipico merged commit 47b951b into withastro:main Jan 5, 2024
@astrobot-houston astrobot-houston mentioned this pull request Jan 5, 2024
Merged
@jacobdalamb jacobdalamb deleted the chore/update-tailwind-readme branch January 5, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@florian-lefebvre florian-lefebvre florian-lefebvre left review comments

@ematipico ematipico ematipico approved these changes

@bluwy bluwy bluwy approved these changes

@lilnasy lilnasy lilnasy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jacobdalamb @ematipico @bluwy @lilnasy @florian-lefebvre