quality of life updates for the node adapter #9582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1a3883b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
github-actions
bot
added
pr: docs
natemoo-re
approved these changes
Jan 8, 2024
github-actions
bot
added
the
pkg: astro
Co-authored-by: Nate Moore <[email protected]>
Fryuni
reviewed
Jan 10, 2024
Co-authored-by: Luiz Ferraz <[email protected]>
lilnasy
commented
Jan 11, 2024
lilnasy
commented
Jan 11, 2024
|
There is a bug-fix in here now. Maybe mention it on the changeset? The race condition bug and silent error happens when calling |
ematipico
reviewed
Jan 11, 2024
Co-authored-by: Emanuele Stoppa <[email protected]>
ematipico
approved these changes
Jan 12, 2024
ematipico
added a commit
that referenced
this pull request
Jan 17, 2024
* quality of life updates for `App` (#9579) * feat(app): writeResponse for node-based adapters * add changeset * Apply suggestions from code review Co-authored-by: Emanuele Stoppa <[email protected]> * Apply suggestions from code review Co-authored-by: Emanuele Stoppa <[email protected]> * add examples for NodeApp static methods * unexpose createOutgoingHttpHeaders from public api * move headers test to core * clientAddress test * cookies test * destructure renderOptions right at the start --------- Co-authored-by: Emanuele Stoppa <[email protected]> * Fallback node standalone to localhost (#9545) * Fallback node standalone to localhost * Update .changeset/tame-squids-film.md * quality of life updates for the node adapter (#9582) * descriptive names for files and functions * update tests * add changeset * appease linter * Apply suggestions from code review Co-authored-by: Nate Moore <[email protected]> * `server-entrypoint.js` -> `server.js` * prevent crash on stream error (from PR 9533) * Apply suggestions from code review Co-authored-by: Luiz Ferraz <[email protected]> * `127.0.0.1` -> `localhost` * add changeset for fryuni's fix * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Emanuele Stoppa <[email protected]> --------- Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Luiz Ferraz <[email protected]> Co-authored-by: Emanuele Stoppa <[email protected]> * chore(vercel): delete request response conversion logic (#9583) * refactor * add changeset * bump peer dependencies * unexpose symbols (#9683) * Update .changeset/tame-squids-film.md Co-authored-by: Sarah Rainsberger <[email protected]> --------- Co-authored-by: Arsh <[email protected]> Co-authored-by: Bjorn Lu <[email protected]> Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Luiz Ferraz <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
App#9579.createOutgoingHeadersis moved intoNodeApp- its logic was duplicated between node and vercel.server-entrypoint.ts(previously "server.ts")serve-static.ts(previously "http-server.ts").serve-app.ts(previouslyhttp-server.tsandnodeMiddleware.ts)log-listening-on.ts(previouslyget-network-address.ts,standalone.ts, andpreview.ts)middleware.ts(previously nodeMiddleware.ts)Testing
No new functionality is introduced. Existing tests should pass.
Docs
Does not affect behavior.