Support remote images with encoded characters #9540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e11e196 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
github-actions
bot
added
the
pr: docs
Princesseuh
reviewed
Dec 28, 2023
| @@ -10,7 +10,7 @@ export function propsToFilename(transform: ImageTransform, hash: string) { | |||
| isESMImportedImage(transform.src) ? transform.src.src : transform.src | |||
| ); | |||
| const ext = extname(filename); | |||
| filename = basename(filename, ext); | |||
| filename = decodeURIComponent(basename(filename, ext)); | |||
There was a problem hiding this comment.
Hmm, while this does fix the problem I'm sure, I wonder what kind of filepath does it generate? Doesn't that mean that for non-encoded slashes it would generate nested directories?
There was a problem hiding this comment.
A non-encoded slash would be removed in the basename() operation.
There was a problem hiding this comment.
Oh yeah, that's true. Awesome then!
Co-authored-by: Florian Lefebvre <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
N/A, bug fix