Add tailwindcss nesting support #9529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5daa15 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
| @@ -23,15 +24,22 @@ async function getPostCssConfig( | |||
|
|
|||
| async function getViteConfiguration( | |||
| tailwindConfigPath: string | undefined, | |||
| viteConfig: UserConfig | |||
| nesting: boolean, | |||
There was a problem hiding this comment.
We're starting to have lots of options here, could it be better to have a single object instead?
There was a problem hiding this comment.
Just an internal function so not a big deal. Going to merge this in but feel free to refactor if you'd like!
matthewp
approved these changes
Dec 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
close #9526
Add
tailwindcss/nestingsupport via an option the user can enable. https://tailwindcss.com/docs/using-with-preprocessors#nestingTesting
Added new tests
Docs
TBA in docs repo. And there's also the added jsdoc.