Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes warning for external URL redirects #9426

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fixes warning for external URL redirects #9426

merged 2 commits into from
Dec 15, 2023

Conversation

alexnguyennz
Copy link
Contributor

Changes

Updates warning e.g.

Redirecting to an external URL is not officially supported: /external -> [object Object]

to

Redirecting to an external URL is not officially supported: /external -> https://example.com

Testing

pnpm run test:match "core"

Docs

N/A

Copy link

changeset-bot bot commented Dec 13, 2023

🦋 Changeset detected

Latest commit: cd2fffe

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 13, 2023
@alexnguyennz alexnguyennz changed the title Update warning for external URL redirects to use destination address Fixes warning for external URL redirects Dec 14, 2023
@ematipico ematipico merged commit c01cc4e into withastro:main Dec 15, 2023
@astrobot-houston astrobot-houston mentioned this pull request Dec 15, 2023
@alexnguyennz alexnguyennz deleted the external-redirect-warning branch January 6, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants