Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vercel): Add beta option for status #9413

Merged

Conversation

jacobdalamb
Copy link
Contributor

@jacobdalamb jacobdalamb commented Dec 12, 2023

Changes

Add's beta option to status enum for supported Node versions.

Closes: #9408

Testing

n/a

Docs

n/a

Copy link

changeset-bot bot commented Dec 12, 2023

🦋 Changeset detected

Latest commit: b2f12b6

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Dec 12, 2023
@github-actions github-actions bot added the pr: docs A PR that includes documentation for review label Dec 12, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jacobdalamb

I left a couple of changes we require. Also, since we are adding a new option, we need to update the README.md and document it.

.changeset/stupid-cheetahs-sell.md Outdated Show resolved Hide resolved
.changeset/stupid-cheetahs-sell.md Outdated Show resolved Hide resolved
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.changeset/stupid-cheetahs-sell.md Outdated Show resolved Hide resolved
packages/integrations/vercel/README.md Outdated Show resolved Hide resolved
Jacob Lamb and others added 2 commits December 13, 2023 01:01
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge once @sarah11918 is happy!

Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@ematipico ematipico merged commit 836ab62 into withastro:main Dec 13, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Dec 13, 2023
@jacobdalamb jacobdalamb deleted the chore/update-supported-node-versions branch December 13, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Node v20 in Vercel adapter
6 participants