refactor(assets): Move things around to avoid importing image service unnecessarily #9409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the way of trying to solve withastro/adapters#58, I realized there's some instances where the image service could get imported by accident because some utils were next to the code that loads it. This refactor move away everything unrelated to that elsewhere, so that people and adapters can import the utilities without anything else coming in by accident.
This doesn't unblock the linked PR just yet, some other bundling nonsense is in the way, however it's a step forward!
Testing
Tests should pass, this is just a refactor!
Docs
N/A