-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure astro add
only installs stable versions
#9387
Conversation
🦋 Changeset detectedLatest commit: 85f85e1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview add-stable |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Thanks for the much needed cleanup.
Changes
astro add svelte
would install5.0.0-next.22
, which is not a stable versionastro add
installation logic to actually resolve the most recent stable version of packages before installing. We do this by querying the registry for all versions and filtering out any prereleases.peerDependency
parserregex has also been removed in favor ofsemver
! It was already a dependency, so we might as well use it.Testing
Tested manually because
astro add
hasalmostno test coverage. Woooooo!Docs
Bug fix only