Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Vue example to use <script setup> #9379

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

morinokami
Copy link
Contributor

Changes

  • Refactor the Vue example to use the now-recommended <script setup> syntax.

Testing

  • Tested locally by running the updated example.

Docs

  • N/A because this is an update of example.

Copy link

changeset-bot bot commented Dec 8, 2023

⚠️ No Changeset found

Latest commit: 4904274

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Dec 8, 2023
import { ref } from 'vue';

const count = ref(0);
const add = () => (count.value = count.value + 1);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it's worth shortening to count.value++?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I agree with your suggestion. Simplifying the code to use count.value++ would make it more concise. I'll make the change. Thanks!

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bluwy bluwy merged commit a0dc4a4 into withastro:main Dec 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants