Fix static build when out dir is not within the cwd #9378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
the
pkg: astro
Changeset
1 task
1 task
matthewp
approved these changes
Dec 13, 2023
|
Fixes #9415 |
taktran
added a commit
to ag-grid/ag-grid
that referenced
this pull request
Mar 5, 2024
* Add patch to use working directory when building static files, see Fix static build when out dir is not within the cwd withastro/astro#9378 * See ag-grid/ag-charts#678 * Add patch to copy over dot files when running build outside of astro folder * See ag-grid/ag-charts@5384e86
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We had an issue where some styles were not loading in the static build. We managed to pinpoint it to this - and noticed
clientBuildcalls this function onconfig.outDir- but the mutations don't. I'm not 100% sure this is the correct fix, but it certainly fixed it for usTesting
Local testing & repo tests
Docs
Fixes static builds when
config.outDiris located outside of the astro project