Add reverted aria audit rules for dev toolbar #9377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg: astro
🦋 Changeset detectedLatest commit: c843b04 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pr: docs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
⚖️ Bundle Size CheckLatest commit: c843b04
|
Princesseuh
approved these changes
Jan 2, 2024
ematipico
approved these changes
Jan 2, 2024
| @@ -489,3 +563,81 @@ const a11y_non_interactive_element_to_interactive_role_exceptions = { | |||
| td: ['gridcell'], | |||
| fieldset: ['radiogroup', 'presentation'], | |||
| }; | |||
|
|
|||
| const combobox_if_list = ['email', 'search', 'tel', 'text', 'url']; | |||
There was a problem hiding this comment.
Can we change snake case names to camel case?
There was a problem hiding this comment.
I can change them to camelCase. It was snake_case as it's borrowed from Svelte and that's the convention they use.
There was a problem hiding this comment.
Seems like there's a lot that uses snake_case. I think maybe we should do one PR later to convert them all at once.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Un-revert #9295 and #9293
The main change is adding
optimizeDeps.include: ['astro > aria-query', 'astro > axobject-query']to fix it.Testing
Tested manually with
pnpm link, andpnpm pack+ install locally (to emulate when it's published)Docs
It doesn't seem like we document the audit rules today.