Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve generating routes that end with .mjs #9374

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Preserve generating routes that end with .mjs #9374

merged 2 commits into from
Dec 8, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 8, 2023

Changes

Fixes #9154

Instead of globbing **/*.mjs to remove the unused SSR outputs, we can use the Rollup output information to remove them instead. This way we only remove the .mjs files that are part of Rollup, and not the ones generated by pages/endpoitns.

Testing

Added a test from the issue

Docs

n/a. bug fix.

Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: 5ce5f45

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 8, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we should eventually align the output structure for server and static outputs, but this is a fine solution for now!

@bluwy bluwy merged commit 65ddb02 into main Dec 8, 2023
13 checks passed
@bluwy bluwy deleted the mjs-no-remove branch December 8, 2023 15:39
@astrobot-houston astrobot-houston mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build process automatically deletes all *.mjs files
2 participants