Adds source file properties to HTML elements only if devToolbar is enabled #9343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 50c4d0e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Princesseuh
approved these changes
Dec 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When the compiler was called, only astro.config.devToolbar was checked to activate the source annotations, but not AstroPerferences.
Now the code mimics the check that we use in router.ts to activate devToolbar.
Closes #9324
Note: The astro.config setting currently takes precedence over preferences. If astro.config.devToolbar === false, preferences cannot turn it back on. I think we should not use preferences and astro.config together or at least give astro.config a lower priority between preferences.global and preferences.default. See thread in #maintainers from this morning (6:40 GMT)
Testing
Manually tested
Docs
Depending on how complicate the final solution might get :)