remove outdated devoverlay config and defaultstate config #9291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
pkg: astro
⚖️ Bundle Size CheckLatest commit: 771c0c8
|
matthewp
approved these changes
Dec 4, 2023
FredKSchott
commented
Dec 4, 2023
| @@ -228,12 +228,7 @@ export class AstroDevOverlay extends HTMLElement { | |||
| width: 1px; | |||
| } | |||
| </style> | |||
| <div id="dev-overlay"${ | |||
| ((window as DevOverlayMetadata)?.__astro_dev_overlay__?.defaultState ?? 'minimized') === | |||
There was a problem hiding this comment.
this is the part that is no longer needed, as the dev overlay is now always hidden to start.
|
Confirmed no impact on docs, since this was never added to docs either during the early 4.0.0-beta.1 days! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
devOverlayconfig was introduced in the4.0.0-beta.Xrelease branch, meaning it is not covered by semver now that it has been renamed todevToolbar. The only people who would have been using this were people experimenting with early versions of the Astro 4.0 beta.devOverlaywas being checked, instead ofdevToolbardevToolbarinstead ofdevOverlaydefaultStateconfig, which was removed in Overlay look-and-feel polish #9230 but the config was missed. This is now a no-op and doesn't make conceptual sense since the toolbar now shows/hides based on hover/focus.Testing
Docs