Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev overlay style leak #9220

Merged
merged 5 commits into from
Nov 29, 2023
Merged

Fix dev overlay style leak #9220

merged 5 commits into from
Nov 29, 2023

Conversation

natemoo-re
Copy link
Member

Changes

  • Closes PLT-1245
  • Sets all: initial on the dev overlay to reset style inheritance.
  • This fixes a problem where global font-size/line-height and other inheritable styles would break the dev overlay.
  • Not including a changeset because it will just go out in the next patch

Testing

Manually. It works!

Docs

Nah

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 11b20df

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Nov 28, 2023
@FredKSchott FredKSchott mentioned this pull request Nov 29, 2023
Merged
@natemoo-re natemoo-re merged commit 4a5f2cd into next Nov 29, 2023
13 checks passed
@natemoo-re natemoo-re deleted the fix/dev-overlay-style-leak branch November 29, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martrapp martrapp martrapp approved these changes

@ematipico ematipico ematipico approved these changes

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@natemoo-re @matthewp @ematipico @martrapp @Princesseuh