fix: links with same path but different search params not prefetched #9189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0982a34 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
1 task
bluwy
reviewed
Nov 27, 2023
sarah11918
reviewed
Nov 27, 2023
There was a problem hiding this comment.
Gave you a couple of different ways you could take this, @bluwy ! Happy for you to use either one, directly or just as "inspiration" and make a final call! 🙌
Co-authored-by: Sarah Rainsberger <[email protected]>
Merged
matthewp
added a commit
that referenced
this pull request
Nov 28, 2023
* feat: implement redesign * fix: make it build * feat: visual tweaks * feat(overlay): update styling, integration endpoint * feat: add fallback icons * Clean up tests (#9183) * Add `@astrojs/upgrade` package for automatic package upgrades (#8525) Co-authored-by: Sarah Rainsberger <[email protected]> * [ci] format * fix: links with same path but different search params not prefetched (#9189) Co-authored-by: Sarah Rainsberger <[email protected]> * fix: discord icon * chore: changeset --------- Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Bjorn Lu <[email protected]> Co-authored-by: Nate Moore <[email protected]> Co-authored-by: Sarah Rainsberger <[email protected]> Co-authored-by: Spencer Whitehead <[email protected]> Co-authored-by: Matthew Phillips <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Links where the path is the same, but search params are not, are prefetched
Testing
e2e test
Docs
As far as I can tell from reading the docs, they do not mention prefetching behavior in this case at all. Since this change aligns it more with expected behavior, I don't think more information would need to be added, but I can write something if necessary.
Open Issue:
fix #9185