Extend the 'click' listener of view transitions to handle links in SVGs and areas in image maps #9140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fe72ebb The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Merged
1 task
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
…Gs and areas in image maps (#9140) * handle clicks on SVGAElements and image maps * add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Currently we only trigger view transitions for clicks on or within HTMLAnchorElements.
This excludes
<a href="" ...>within SVG elements, which are technically not HTMLElements but SVGAElements, see #9001. This change fixes that issue and now also includes HTMLAreaElements, so you also get view transitions when you click inside your beloved image maps.Closes #9001
Testing
Added e2e test cases
Docs
Most users will not recognize the difference between an
<a href=inside or outside of<svg>...</svg>. So this part is not really an extension, but a bug fix. The support for image maps is an extension, but of a more theoretical nature. It is said that they were last used in the 90s.