-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all dependencies #9138
Update all dependencies #9138
Conversation
also add Chris as co-author for the first commit Co-authored-by: delucis <[email protected]>
🦋 Changeset detectedLatest commit: c80c408 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -1317,7 +1317,7 @@ export interface AstroUserConfig { | |||
* { | |||
* markdown: { | |||
* // Example: Translate the footnotes text to another language, here are the default English values | |||
* remarkRehype: { footnoteLabel: "Footnotes", footnoteBackLabel: "Back to content"}, | |||
* remarkRehype: { footnoteLabel: "Footnotes", footnoteBackLabel: "Back to reference 1"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change from syntax-tree/mdast-util-to-hast@56c88e4, but it's very unlikely to affect someone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do I understand correctly that the breaking change is the default wording is now different?
This change in default looks good to me (more accessible than many identical links), but we should maybe include a link in the changeset, just in case someone wants to update their text. (I think it's likely to affect people, but unlikely that that affect is bad/undesired.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's the changed default. I can add a changeset here, maybe together with that we've upgraded the remark/rehype plugins
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changeset looks good — thanks for adding that @bluwy!
Changes
This upgrades all dependencies including breaking ones, except:
@lit-labs/ssr-client
: pinned due to 2.0 regressions before@lit-labs/ssr
: pinned due to 2.0 regressions beforelit
: we don't support v3 yet@types/node
: keeping it as v18 for now instead of v20Testing
Ran
pnpm test
at the root to run all tests (passes)Docs
The main upgrades to document are for the remark/rehype plugins, the migration guide can touch on this a bit.